← Back to issue list

Snapcraft doesn't inject itself into build VM if host rev doesn't change

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1893850
Type
issue
State
open
Author
~kyrofa
Labels
Created
2020-09-01 20:57:56.934435+00:00
Updated
2020-09-11 15:45:21.744194+00:00
Closed

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

I'm developing new snapcraft features. These features require that a snapcraft snap be built (using the stable release of snapcraft). Then that new snapcraft snap needs to be installed (which changes the snapcraft revision to x1). Then I actually run it, a build VM is created, and snapcraft injects itself and continues on its merry way. Then of course I hit a bug, and go through those steps again: 1. Uninstall snapcraft 2. Install snapcraft from stable 3. Build snapcraft with bug hopefully fixed 4. Install new snapcraft (back to revision x1 again) 5. Run snapcraft on test project. 6. Notice bug is still there, as if nothing changed! That's because it didn't-- snapcraft noticed that it was still on revision x1, and didn't inject the new version, thereby continuing to use the old, buggy version in the build VM. Snapcraft should be checking hashes, not revisions (at least, when the revisions start with "x"). Now, one could point out that (1) should be `snap revert snapcraft`, but that doesn't change the fact that this is still a bug. Besides, actually removing/reinstalling snapcraft after sideloading over the top of it is the only sure-fired way to make sure I'm using the right thing.

Evaluation history

No evaluation history available.